-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
feat(benchmark): support profiling #19789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
273b1e7 to
1407aea
Compare
1407aea to
6a4c4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do changes step by step, otherwise diff are dirty and hard to read and understand
- Let's keep benchmarks in
testdirectory right (we can move them at the last step) - We keep generated code in
./test/js/<name>, so let's store generated code there (we want to rename this directory totest/outputs/<name>soon) - Let's add profiling and other feature to
BenchmarkTestCases.benchmark.mjs(and not only) in other PR, because I can't see diff due to moving files to other directory and it is hard to understand what we changed
|
Sorry! Indeed, I'll simplify this to only add profiling support and such |
|
Also we are trying to using |
b0dd035 to
0e10311
Compare
alexander-akait
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
CodSpeed Performance ReportMerging #19789 will degrade performances by 75.03%Comparing Summary
Benchmarks breakdown
|
|
@avivkeller As you can see, our watch tests are not stable (not related to your changes), if you have time to look at what's wrong with them will be great |
Hiya! @ovflowd mentioned to me that y'all are looking to speed up parts of Webpack. That's great, and I'm happy to help. Anyhow, I wanted to help, so I figured I'd start by looking at the benchmarks, and immediately noticed a few things I could improve: Benchmarks don't profile
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
The tests are the benchmarks
Does this PR introduce a breaking change?
I certainly hope not.
What needs to be documented once your changes are merged?
The documentation has already been updated