Skip to content

fix svg color for dark mode #5957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix svg color for dark mode #5957

merged 1 commit into from
Feb 11, 2022

Conversation

chenxsan
Copy link
Member

Should be white:

CleanShot 2022-02-10 at 20 00 47@2x

CleanShot 2022-02-10 at 20 01 19@2x

@vercel
Copy link

vercel bot commented Feb 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/B3aLzHzFjDigy8A8EUbM9htxeWeH
✅ Preview: https://webpack-js-org-git-fork-chenxsan-bugfix-fix-ea68e9-webpack-docs.vercel.app

snitin315
snitin315 approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenxsan chenxsan merged commit 6940749 into webpack:master Feb 11, 2022
@chenxsan chenxsan deleted the bugfix/fix-svg-dark-mode branch February 11, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snitin315 snitin315 snitin315 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenxsan @snitin315