Skip to content

document for specifying the buildHttp.proxy for HttpUrlPlugin #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

aleen42
Copy link
Contributor

@aleen42 aleen42 commented Feb 10, 2022

For webpack/webpack#15354

closes #5994

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.
  • Remove these instructions from your PR as they are for your eyes only.

@vercel
Copy link

vercel bot commented Feb 10, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/89CFGd32f8MsmdSmoWGvhforrQoC
✅ Preview: https://webpack-js-org-git-fork-aleen42-proxy-webpack-docs.vercel.app

Copy link
Member

@chenxsan chenxsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your patience. I've left some suggestions, let me know what you think.


- Type: `string`

By default webpack would try to use the `http_proxy` environment variable to specify the proxy server for remote resources. Besides, you can define the proxy server by setting the `proxy` option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default webpack would try to use the `http_proxy` environment variable to specify the proxy server for remote resources. Besides, you can define the proxy server by setting the `proxy` option.
By default webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` environment variable. However, you can also specify one through the `proxy` option.

Should it be https_proxy?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that using http_proxy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this case sensitive? or both http_proxy/HTTP_PROXY works?

Copy link
Contributor Author

@aleen42 aleen42 Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both works, how about

- By default webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` environment variable. However, you can also specify one through the `proxy` option.
+ By default, Webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` (case insensitive) environment variable. However, you can also specify one through the `proxy` option.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. /cc @chenxsan

@chenxsan chenxsan merged commit e7eca65 into webpack:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document webpack change: support using proxy sockets within HttpUrlPlugin
3 participants