-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
document for specifying the buildHttp.proxy
for HttpUrlPlugin
#5956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/89CFGd32f8MsmdSmoWGvhforrQoC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for your patience. I've left some suggestions, let me know what you think.
|
||
- Type: `string` | ||
|
||
By default webpack would try to use the `http_proxy` environment variable to specify the proxy server for remote resources. Besides, you can define the proxy server by setting the `proxy` option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default webpack would try to use the `http_proxy` environment variable to specify the proxy server for remote resources. Besides, you can define the proxy server by setting the `proxy` option. | |
By default webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` environment variable. However, you can also specify one through the `proxy` option. |
Should it be https_proxy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that using http_proxy
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this case sensitive? or both http_proxy
/HTTP_PROXY
works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both works, how about
- By default webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` environment variable. However, you can also specify one through the `proxy` option.
+ By default, Webpack would imply the proxy server to use for fetching remote resources from the `http_proxy` (case insensitive) environment variable. However, you can also specify one through the `proxy` option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. /cc @chenxsan
Signed-off-by: Aleen <[email protected]>
For webpack/webpack#15354
closes #5994