Skip to content

fix a little typo #2829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 24, 2019
Merged

fix a little typo #2829

merged 2 commits into from
Feb 24, 2019

Conversation

aularon
Copy link

@aularon aularon commented Feb 24, 2019

fixing a typo removing function's parenthesis, as we are assigning the function reference rather than its call return value

@aularon
fix a little typo
ec0188e 
we are assigning the function reference rather than its call return value
EugeneHlushko
EugeneHlushko approved these changes Feb 24, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah someone improved the code above and forgot to update this reference

@EugeneHlushko EugeneHlushko merged commit 4b1faa0 into webpack:master Feb 24, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Guides
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aularon @EugeneHlushko @montogeek