Skip to content

docs(Config.Optimization): correct typo namedChunks -> chunkIds #2827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2019
Merged

docs(Config.Optimization): correct typo namedChunks -> chunkIds #2827

merged 1 commit into from
Feb 24, 2019

Conversation

bhongy
Copy link
Contributor

@bhongy bhongy commented Feb 23, 2019 •
edited
Loading

Correct typo (incorrect reference) in: Configuration: optimization.chunkIds.

screen shot 2019-02-23 at 11 12 08 am

The last bullet point currently reads
"if none of the above, optimization.namedChunks will be defaulted to 'natural'"

which should have been
"if none of the above, optimization.chunkIds will be defaulted to 'natural'"

EugeneHlushko
EugeneHlushko approved these changes Feb 24, 2019
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes makes sense 👍 good catch

@EugeneHlushko EugeneHlushko merged commit 7ba9709 into webpack:master Feb 24, 2019
@EugeneHlushko
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhongy @EugeneHlushko