Skip to content

Revert "cacheGroups" #2725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 18, 2018
Merged

Revert "cacheGroups" #2725

merged 10 commits into from
Dec 18, 2018

Conversation

EugeneHlushko
Copy link
Member

Reverts #2227

@EugeneHlushko
Revert "docs(configuration): Add default for parallelism (#2481)"
d10f49a 
This reverts commit 13c3156.
@EugeneHlushko
Revert "Update split-chunks-plugin.md"
c3446c1 
This reverts commit 91ed804.
@EugeneHlushko
Revert "Update split-chunks-plugin.md"
42f05d9 
This reverts commit f93ee59.
@EugeneHlushko
Revert "docs(guides): Update hot-module-replacement.md (#2418)"
560e4b0 
This reverts commit 2277189.
@EugeneHlushko
Revert "docs(plugins) splitChunks enforce doesnt make maxSize ignored…
ad568fc 
… anymore (#2687)"

This reverts commit da1752e.
@EugeneHlushko
Revert "docs(guides): Small readme improvements, remove the word "sim…
edff383 
…ple" (#2671)"

This reverts commit 99b0355.
@EugeneHlushko
Revert "docs(API) Add error report introduction of loaders (#2231) (#…
9d6a271 
…2298)"

This reverts commit 29ce0ef.
@EugeneHlushko
Revert "docs(concepts): Add a warning note for common errors when spe…
92d9637 
…cifying rules (#2376)"

This reverts commit db50ffb.
@EugeneHlushko
Revert "docs(plugins): Add example on how to tree shake locales from …
12726fc 
…date-fns (#2524)"

This reverts commit 1349ca6.
@EugeneHlushko
Revert "docs(plugins): Add title to cacheGroups (#2227)"
955d4a2 
This reverts commit 5b3906e.
@EugeneHlushko
Copy link
Member Author

I dont know why this got merged, result is on screenshot:

screen shot 2018-12-17 at 11 17 54 am

Basically before reuseexistingChunk example there is duplicated heading of the next section, also it is misformatted, we use curly for cacheGroup abstraction as its not real cacheGroup name: splitChunks.cacheGroups.{cacheGroup}.test vs splitChunks.cacheGroups.cacheGroup.test

@EugeneHlushko
Copy link
Member Author

Very weird revert commit list by github interface

@EugeneHlushko
Copy link
Member Author

We would need to revert exactly that one commit and not all these, can you handle that @montogeek ?

@montogeek
Copy link
Member

montogeek commented Dec 17, 2018 •
edited
Loading

Yep, I will revert it tonight.

@montogeek
Copy link
Member

It got merged because I didn't pay enough attention.

@montogeek montogeek merged commit 51232cc into master Dec 18, 2018
@montogeek montogeek deleted the revert-2227-patch-1 branch December 18, 2018 10:31
@montogeek
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montogeek montogeek Awaiting requested review from montogeek

Assignees
No one assigned
Labels
Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EugeneHlushko @montogeek