Skip to content

Update hot-module-replacement.md #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 16, 2018
Merged

Conversation

aviyacohen
Copy link
Contributor

Only added a parenthesis tip that will hopefully help future readers getting stuck on the same part I did. The tutorial updates the button.onclick printMe() only a couple of steps after enabling HMR and a focused user might think the code is not working when the output from the button click to the console.log does not update with the HMR changes.

Only added a parenthesis tip that will hopefully help future readers getting stuck on the same part I did. The tutorial updates the button.onclick printMe() only a couple of steps after enabling HMR and a focused user might think the code is not working when the output from the button click to the console.log does not update with the HMR changes.
@@ -103,7 +105,7 @@ __index.js__
+ }
```

Start changing the `console.log` statement in `print.js`, and you should see the following output in the browser console.
Start changing the `console.log` statement in `print.js`, and you should see the following output in the browser console (don't worry about that `button.onclick = printMe()` output for now, we also update that part later).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will also... should be instead.

@montogeek montogeek requested a review from EugeneHlushko August 4, 2018 10:47
@EugeneHlushko
Copy link
Member

I am not convinced that this is required, the guide is well structured and covers that part later on. Maybe someone benefits from these kind of hints, but only because they stop reading half way through the guide? I don't say i am against this addition, just would love to hear few more thumbs up for the addition before approving it

@montogeek montogeek merged commit 2277189 into webpack:master Dec 16, 2018
@montogeek
Copy link
Member

Thanks!

EugeneHlushko added a commit that referenced this pull request Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants