Update hot-module-replacement.md #2418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only added a parenthesis tip that will hopefully help future readers getting stuck on the same part I did. The tutorial updates the button.onclick printMe() only a couple of steps after enabling HMR and a focused user might think the code is not working when the output from the button click to the console.log does not update with the HMR changes.
montogeek
requested changes
Aug 3, 2018
| @@ -103,7 +105,7 @@ __index.js__ | |||
| + } | |||
| ``` | |||
|
|
|||
| Start changing the `console.log` statement in `print.js`, and you should see the following output in the browser console. | |||
| Start changing the `console.log` statement in `print.js`, and you should see the following output in the browser console (don't worry about that `button.onclick = printMe()` output for now, we also update that part later). | |||
There was a problem hiding this comment.
we will also... should be instead.
dhruvdutt
approved these changes
Aug 4, 2018
|
I am not convinced that this is required, the guide is well structured and covers that part later on. Maybe someone benefits from these kind of hints, but only because they stop reading half way through the guide? I don't say i am against this addition, just would love to hear few more thumbs up for the addition before approving it |
montogeek
approved these changes
Dec 16, 2018
|
Thanks! |
EugeneHlushko
added a commit
that referenced
this pull request
Dec 17, 2018
This reverts commit 2277189.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only added a parenthesis tip that will hopefully help future readers getting stuck on the same part I did. The tutorial updates the button.onclick printMe() only a couple of steps after enabling HMR and a focused user might think the code is not working when the output from the button click to the console.log does not update with the HMR changes.