Skip to content

Adding a note about splitChunks.name = false functionality #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2018
Merged

Adding a note about splitChunks.name = false functionality #2672

merged 3 commits into from
Dec 12, 2018

Conversation

weaverryan
Copy link
Contributor

Hi people!

This adds a note about what splitChunks.name = false means and that it is probably a good setting for production. This (hopefully) is an easy win, as it was recommended by sokra: webpack/webpack#8426 (comment)

Thanks!

@weaverryan weaverryan mentioned this pull request Nov 28, 2018
Closed
EugeneHlushko
EugeneHlushko reviewed Nov 30, 2018
View reviewed changes
Copy link
Member

@EugeneHlushko EugeneHlushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting moving it to a note block and doing a small rephrase including getting rid of the colons. what do you think?

@EugeneHlushko EugeneHlushko merged commit 8518cbb into webpack:master Dec 12, 2018
@EugeneHlushko
Copy link
Member

Thanks!

@weaverryan weaverryan deleted the document-split-chunks-name-false branch December 17, 2018 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EugeneHlushko EugeneHlushko EugeneHlushko approved these changes

Assignees
No one assigned
Labels
Plugins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weaverryan @EugeneHlushko @montogeek