Add GitHub token to GitHub API calls #2270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montogeek
changed the title
| organization: organization, | ||
| suffix: suffix | ||
| }, | ||
| function(err, d) { |
There was a problem hiding this comment.
can you define the error handler outside of function call and just pass it here pls? This would make it even more readable, same goes for following error handler
There was a problem hiding this comment.
Out of the scope of this PR, I just reformatted that file, actually I should revert it.
Also, we should change how fetch script works, one is reading stdout from the previous one, making it harder to test in isolation.
There was a problem hiding this comment.
nah dont revert, formatting is good now
|
One stylistic comment otherwise LGTM |
EugeneHlushko
approved these changes
Jun 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1963 that actually works.
Travis scripts runs in a child process which doesn't inherit environment variables, so you have to re export them.
See https://travis-ci.org/webpack/webpack.js.org/builds/392673634?utm_source=github_status&utm_medium=notification for logs regarding rate limits, it says 5000 instead of 60. I hope this will solve our constant failed builds.