test: add snapshots for page errors #3835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
requested review from
alexander-akait,
anshumanv,
hiroppy and
knagaitsev
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
- Coverage 92.81% 92.67% -0.15%
==========================================
Files 14 14
Lines 1337 1337
Branches 472 472
==========================================
- Hits 1241 1239 -2
- Misses 88 90 +2
Partials 8 8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Added more assertions.
Motivation / Use-Case
Add snapshots for page errors like the rest of the tests.
Breaking Changes
None
Additional Info
No