chore: warning when proxy property is undefined #3647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evenstensberg
requested review from
alexander-akait,
anshumanv,
hiroppy,
knagaitsev and
snitin315
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3647 +/- ##
=======================================
Coverage 93.87% 93.88%
=======================================
Files 15 15
Lines 1289 1291 +2
Branches 443 443
=======================================
+ Hits 1210 1212 +2
Misses 72 72
Partials 7 7
Continue to review full report at Codecov.
|
snitin315
reviewed
Aug 15, 2021
| return createProxyMiddleware(context, proxyConfig); | ||
| } | ||
| this.logger.warn( | ||
| `The "target" value specified in the "proxy" property ${context} is not defined and will be skipped.` |
Member
There was a problem hiding this comment.
for better visibility
Suggested change
| `The "target" value specified in the "proxy" property ${context} is not defined and will be skipped.` | |
| `The "target" value specified in the "proxy" property "${context}" is not defined and will be skipped.` |
Can you also add a simple test case in https://github.com/webpack/webpack-dev-server/blob/master/test/server/proxy-option.test.js ?
alexander-akait
requested changes
Aug 16, 2021
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Bad idea, we should allow to use proxy without target, it is valid case
Member
|
WIP on fix |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No
Motivation / Use-Case
When the
proxyproperty target is undefined, the user doesn't know, and it's nice to know its being skipped.Breaking Changes
No
Additional Info
:)