Skip to content

fix: content security policy issue in client log #3078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

snitin315
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Manually tested against given reproduction https://github.com/bedrich-schindler/webpack-dev-server-reproducible-3040

Motivation / Use-Case

Fixes #3062
Fixes #3040

Breaking Changes

Additional Info

No

Co-authored-by: Morten N.O. Nørgaard Henriksen <[email protected]>
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #3078 (b052a43) into master (09a31d0) will not change coverage.
The diff coverage is n/a.

❗ Current head b052a43 differs from pull request most recent head 68e3aad. Consider uploading reports for the commit 68e3aad to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3078   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files          37       37           
  Lines        1261     1261           
  Branches      328      328           
=======================================
  Hits         1164     1164           
  Misses         92       92           
  Partials        5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09a31d0...68e3aad. Read the comment docs.

@alexander-akait
Copy link
Member

Looks good, but I need check the code and ensure we don't break something, I will do it in near future

@snitin315
Copy link
Member Author

@alexander-akait anything else we need to fix before release?

@alexander-akait
Copy link
Member

We should check IE 11 support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSP WebSocket.client.onmessage CSP headers cannot be set with webpack-dev-server v4
2 participants