test: support webpack5 #2553
Merged
test: support webpack5 #2553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2020
hiroppy
force-pushed
the
feature/update-tests-for-webpack5
branch
from
970fb5a to
d84e0b3
Compare
Codecov Report
@@ Coverage Diff @@
## v4 #2553 +/- ##
=======================================
Coverage 93.36% 93.36%
=======================================
Files 34 34
Lines 1327 1327
Branches 375 375
=======================================
Hits 1239 1239
Misses 85 85
Partials 3 3
Continue to review full report at Codecov.
|
hiroppy
force-pushed
the
feature/update-tests-for-webpack5
branch
from
d84e0b3 to
bd17de4
Compare
hiroppy
force-pushed
the
feature/update-tests-for-webpack5
branch
from
bd17de4 to
056ca06
Compare
knagaitsev
reviewed
Apr 30, 2020
|
|
||
| const webpack = require('webpack'); | ||
|
|
||
| const isWebpack5 = webpack.version[0] === '5'; |
There was a problem hiding this comment.
should this have a try-catch around it, or have all versions of webpack had a .version value?
There was a problem hiding this comment.
yes, webpack4 and webpack5 have version function and we don't take care of less than v4 so it's okay.
There was a problem hiding this comment.
Oh, didn't see that this is just being used for test files
knagaitsev
approved these changes
Apr 30, 2020
alexander-akait
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Updated.
Motivation / Use-Case
Fixed some tests to support webpack5.
Need to merge this pr asap.
Breaking Changes
Additional Info