BREAKING CHANGE(server): get rid of conditions of Node version #2552
Conversation
| // https://github.com/spdy-http2/node-spdy/issues/350 | ||
| // https://github.com/webpack/webpack-dev-server/issues/1592 | ||
| if (this.options.http2) { | ||
| // TODO: we need to replace spdy with http2 which is an internal module |
There was a problem hiding this comment.
Ideally, we wanna use http2 which is an internal module but we don't have enough time to implement because the interface isn't the same, so we use spdy for all Node versions because spdy supports 10, 12, and 14.
|
commitlint doesn't accept BREAKING CHANGE prefix lol |
Codecov Report
@@ Coverage Diff @@
## v4 #2552 +/- ##
==========================================
+ Coverage 93.36% 93.48% +0.11%
==========================================
Files 34 34
Lines 1327 1320 -7
Branches 375 373 -2
==========================================
- Hits 1239 1234 -5
+ Misses 85 83 -2
Partials 3 3
Continue to review full report at Codecov.
|
|
#2553 must be merged first. |
|
@hiroppy need rebase 👍 |
azure-pipelines.yml
Outdated
| webpack_version: latest | ||
| node-10-canary: | ||
| node_version: ^10.13.0 | ||
| node_version: ^10.20.1 |
There was a problem hiding this comment.
This is the latest version but you want to lock the v10.13.0? Anyway, http2 is supported over v10.10.0 so I'm fine either way.
There was a problem hiding this comment.
@hiroppy azure and github actions by default install latest version if you use ^10.13
There was a problem hiding this comment.
yes I know but I don't know why you are sticking to v10.13.0. What are the benefits of fixing?
There was a problem hiding this comment.
@hiroppy by default we support minimum LTS
There was a problem hiding this comment.
No, LTS is just v10, not v10.13. https://nodejs.org/ja/about/releases/
hiroppy
force-pushed
the
feature/remove-version-condition
branch
from
e0c3129 to
00f8422
Compare
package.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| "client" | |||
| ], | |||
| "engines": { | |||
| "node": ">= 6.11.5" | |||
| "node": ">= 10.20.1" | |||
There was a problem hiding this comment.
I think 10.10 is better than 10.13 because this version supports http2 as a stable.
There was a problem hiding this comment.
10.13 is LTS and we support LTS
There was a problem hiding this comment.
Also webpack@5 support 10.13 as minimum, so we should support this range too
There was a problem hiding this comment.
webpack@5 support 10.13 as minimum
ok, your answer is good for me. but 10.13 isn't minimum LTS.
There was a problem hiding this comment.
10.12.0 - is not LTS https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2018-10-10-version-10120-current-targos
10.13.0 - is LTS https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V10.md#2018-11-27-version-10140-dubnium-lts-rvagg
So we should support minimum supported LTS and now it is 10.13
There was a problem hiding this comment.
thank you for sharing this info.
hiroppy
force-pushed
the
feature/remove-version-condition
branch
from
00f8422 to
4cc6dab
Compare
|
I've changed the commit message from BREAKING CHANGE to fix because CI is going to fail when using BREAKING CHANGE. |
For Bugs and Features; did you add new tests?
Updated.
Motivation / Use-Case
Drop conditions of Node version.
Breaking Changes
Yes
Additional Info