Skip to content

Conversation

knagaitsev
Copy link
Collaborator

@knagaitsev knagaitsev commented Jun 11, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Jest seems to have problems with the browser taking a while to close after a test has failed. Running tests after the browser has closed seems to be a workaround. I believe this will fix hanging on Windows CI.

Breaking Changes

None

Additional Info

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #2018 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2018   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          29       29           
  Lines        1149     1149           
  Branches      327      327           
=======================================
  Hits         1066     1066           
  Misses         79       79           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 303f4e9...3989160. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@alexander-akait alexander-akait merged commit f611304 into webpack:master Jun 13, 2019
@knagaitsev knagaitsev added gsoc Google Summer of Code type: test labels Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc Google Summer of Code type: test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants