refactor(findport): don't listen to http error event

[hiroppy]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

• stop to listen to error event
• findPort function used tryCount variable, but portfinder has stopPort option, so I modify to define stopPort is defaultPort + retryCount
• move definePort logic from bin to findPort.js
• add tests.

Breaking Changes

no

Additional Info

[codecov]

Codecov Report

Merging #1924 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage      88%   87.96%   -0.05%     
==========================================
  Files          14       15       +1     
  Lines         817      814       -3     
  Branches      259      259              
==========================================
- Hits          719      716       -3     
  Misses         84       84              
  Partials       14       14

Impacted Files	Coverage Δ
lib/utils/findPort.js	100% <100%> (+5.26%)	⬆️
lib/utils/tryParseInt.js	83.33% <0%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0baa0e0...d8bf2a2. Read the comment docs.

[hiroppy]

I think codecov has been broken...
For example, this pr updated only puppeteer but lib/Server.js was increased coverage by 3.18%.
#1921 (comment)

[alexander-akait]

Good job