Skip to content

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Mar 25, 2021

What kind of change does this PR introduce?
Update test snapshots

Did you add tests for your changes?
Update test snapshots

If relevant, did you update the documentation?
N/A

Summary
Fix CI
#2544

Does this PR introduce a breaking change?
Nope

Other information
N/A

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner March 25, 2021 16:09
anshumanv
anshumanv previously approved these changes Mar 25, 2021
snitin315
snitin315 previously approved these changes Mar 25, 2021
@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2557 (3b1a647) into master (665d993) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2557      +/-   ##
==========================================
+ Coverage   90.74%   90.98%   +0.23%     
==========================================
  Files          29       29              
  Lines        1459     1464       +5     
  Branches      416      419       +3     
==========================================
+ Hits         1324     1332       +8     
+ Misses        135      132       -3     
Impacted Files Coverage Δ
packages/generators/src/handlers/default.ts 100.00% <100.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c96b69...3b1a647. Read the comment docs.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need fix CI (maybe cache issue?)

@anshumanv anshumanv merged commit d039472 into master Mar 26, 2021
@anshumanv anshumanv deleted the update-snapshots branch March 26, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants