feat: add --analyze flag #1853
Merged
feat: add --analyze flag #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
force-pushed
the
feat/analyze-flag
branch
from
5c1b47b to
12018e1
Compare
snitin315
force-pushed
the
feat/analyze-flag
branch
from
4edf4e7 to
770edbc
Compare
alexander-akait
previously approved these changes
Oct 3, 2020
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Good work
/cc @webpack/cli-team
Member
Author
|
Timeout error on windows CI 😞 . |
Member
|
execa sometimes buggy on windows, do you have windows? |
Member
Author
|
Not me, Anyone else with windows @webpack/cli-team ? |
snitin315
force-pushed
the
feat/analyze-flag
branch
from
29ffa09 to
8b6d0cf
Compare
snitin315
force-pushed
the
feat/analyze-flag
branch
2 times, most recently
from
862f6e1 to
82b935d
Compare
evenstensberg
previously approved these changes
Oct 4, 2020
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
| error(`It looks like ${yellow('webpack-bundle-analyzer')} is not installed.`); | ||
| process.exitCode = 2; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Can we ask to install webpack-bundle-analyzer here?
snitin315
dismissed stale reviews from alexander-akait and evenstensberg
via
27a2d15
snitin315
force-pushed
the
feat/analyze-flag
branch
from
528a23e to
27a2d15
Compare
Member
Author
|
/cc @webpack/cli-team |
alexander-akait
approved these changes
Oct 5, 2020
webpack-bot
added
PR: reviewed-approved
and removed
PR: review-outdated
PR: unreviewed
labels
rishabh3112
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
WIP
If relevant, did you update the documentation?
WIP
Summary
Invoke
webpack-bundle-analyzerplugin via--analyzeflag.Does this PR introduce a breaking change?
No
Other information
Fixes #1838