Skip to content

refactor: migrate to async/await #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 2 commits into from
Sep 21, 2020
Merged

refactor: migrate to async/await #1813

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acf87a2
refactor(migrate): use async/await
jamesgeorge007 Sep 20, 2020
6b7d391
refactor: remove redundant arg for path.resolve()
jamesgeorge007 Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions packages/migrate/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,38 +171,37 @@ function runMigration(currentConfigPath: string, outputConfigPath: string): Prom
* function.
*/

export default function migrate(...args: string[]): void | Promise<void> {
export default async function migrate(...args: string[]): Promise<void> {
const filePaths = args;
if (!filePaths.length) {
logger.error('\n ✖ Please specify a path to your webpack config\n');
return;
}

const currentConfigPath = path.resolve(process.cwd(), filePaths[0]);
const currentConfigPath = path.resolve(filePaths[0]);
let outputConfigPath: string;

if (!filePaths[1]) {
return inquirer
.prompt([
try {
const { confirmPath } = await inquirer.prompt([
{
default: 'Y',
message: 'Migration output path not specified. ' + 'Do you want to use your existing webpack ' + 'configuration?',
message: 'Migration output path not specified. Do you want to use your existing webpack configuration?',
name: 'confirmPath',
type: 'confirm',
},
])
.then((ans: { confirmPath: boolean }): void | Promise<void> => {
if (!ans.confirmPath) {
logger.error('✖ ︎Migration aborted due to no output path');
return;
}
outputConfigPath = path.resolve(process.cwd(), filePaths[0]);
return runMigration(currentConfigPath, outputConfigPath);
})
.catch((err: object): void => {
logger.error(err);
});
]);
if (!confirmPath) {
logger.error('✖ ︎Migration aborted due to no output path');
return;
}
outputConfigPath = path.resolve(filePaths[0]);
return runMigration(currentConfigPath, outputConfigPath);
} catch (err) {
logger.error(err);
return;
}
}
outputConfigPath = path.resolve(process.cwd(), filePaths[1]);
outputConfigPath = path.resolve(filePaths[1]);
return runMigration(currentConfigPath, outputConfigPath);
}