Skip to content

Conversation

@danez
Copy link
Collaborator

@danez danez commented Feb 14, 2019

Q A
Bug fix? yes
Breaking change? yes
New feature? no
Deprecations? no
Tests added? yes
Docs updated? yes
Fixed tickets Fixes #168
License MIT

This removes the grunt template handling in Plugins, as cloning plugins breaks a lot of cases.

@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #171 into master will decrease coverage by 1.38%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   63.59%   62.21%   -1.39%     
==========================================
  Files           8        8              
  Lines         239      217      -22     
  Branches       63       54       -9     
==========================================
- Hits          152      135      -17     
+ Misses         73       70       -3     
+ Partials       14       12       -2
Impacted Files Coverage Δ
tasks/webpack-dev-server.js 12.06% <0%> (+0.4%) ⬆️
src/options/OptionHelper.js 97.36% <100%> (+6.29%) ⬆️
tasks/webpack.js 77.55% <50%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b9b9a...3e1a436. Read the comment docs.

@danez danez force-pushed the better-integration branch from 4205864 to 3e1a436 Compare February 14, 2019 02:27
@danez danez merged commit e31fccb into master Feb 14, 2019
@danez danez deleted the better-integration branch February 14, 2019 03:55
@anbaran
Copy link

anbaran commented Feb 28, 2019

Hi!
When do you plan to build new version of grunt-webpack with these changes?

@yoyossef
Copy link

Hello, same question.
My AOT configuration can only work with that fix (tested it on my project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when starting @ngtools/webpack plugin via "grunt-webpack"

4 participants