concat directory separators instead of "/" to make it work on Windows

[Gohan]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch node-loader@1.0.2 for the project I'm working on.

The problem:

node-loader won't work well with Quasar-framework + electron + webpack process flow on Windows:

the generate code: process.dlopen(module, __dirname + "/" + __webpack_public_path__ + ${JSON.stringify(name)}${typeof options.flags !== 'undefined' ? , ${JSON.stringify(options.flags)} : ''}); fails with "/" on windows platform.

I tried to use require("path").sep to make the loader more platform sensitive for Windows compability

Here is the diff that solved my problem:

diff --git a/node_modules/node-loader/dist/index.js b/node_modules/node-loader/dist/index.js
index b57fb73..fef0365 100644
--- a/node_modules/node-loader/dist/index.js
+++ b/node_modules/node-loader/dist/index.js
@@ -31,7 +31,7 @@ function loader(content) {
   this.emitFile(name, content);
   return `
 try {
-  process.dlopen(module, __dirname + "/" + __webpack_public_path__ + ${JSON.stringify(name)}${typeof options.flags !== 'undefined' ? `, ${JSON.stringify(options.flags)}` : ''});
+  process.dlopen(module, __dirname + require("path").sep + __webpack_public_path__ + ${JSON.stringify(name)}${typeof options.flags !== 'undefined' ? `, ${JSON.stringify(options.flags)}` : ''});
 } catch (error) {
   throw new Error('node-loader:\\n' + error);
 }

This issue body was partially generated by patch-package.

[alexander-akait]

PR welcome

[Gohan]

PR welcome

#40
pending licence/cla Pending — Contributor License Agreement is not signed yet.
https://cla.js.foundation/webpack-contrib/node-loader?pullRequest=40

don't know how to signed..

[alexander-akait]

You need use the same email in commits

[Gohan]

You need use the same email in commits

Has pass the PR check

[alexander-akait]

Fixed