Skip to content

Conversation

TrySound
Copy link

Looks like || {} can be omitted.

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Good to have less dependencies in node_modules

Breaking Changes

Yes, node version bumped

Additional Info

Looks like `|| {}` can be omitted.
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #554 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files           5        5           
  Lines         428      428           
  Branches       96       95    -1     
=======================================
  Hits          379      379           
  Misses         47       47           
  Partials        2        2           
Impacted Files Coverage Δ
src/loader.js 89.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b146549...ac57573. Read the comment docs.

@alexander-akait
Copy link
Member

Thanks for the PR, already in WIP with more improvements #552, ETA is the next week

@TrySound
Copy link
Author

Oh, great! Didn't get the title.

@TrySound TrySound closed this Sep 2, 2020
@TrySound TrySound deleted the upgrade-loader-utils branch September 2, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants