Skip to content

ci: add Node.js 24 #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2025
Merged

ci: add Node.js 24 #1136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e144fd2
ci: add Node.js 24
alexander-akait Aug 4, 2025
c6aa945
test: fix
alexander-akait Aug 4, 2025
0477f37
test: fix
alexander-akait Aug 4, 2025
bf26ea1
test: fix
alexander-akait Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x]
webpack-version: [latest]

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -127,7 +127,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x]
node-version: [12.x, 14.x, 16.x, 18.x, 20.x, 22.x, 24.x]

runs-on: ${{ matrix.os }}

Expand Down
8 changes: 6 additions & 2 deletions test/TestCases.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,19 @@ function clearDirectory(dirPath) {
for (let i = 0; i < files.length; i++) {
const filePath = `${dirPath}/${files[i]}`;

if (fs.statSync(filePath).isFile()) {
if (fs.existsSync(filePath) && fs.statSync(filePath).isFile()) {
fs.unlinkSync(filePath);
} else {
clearDirectory(filePath);
}
}
}

fs.rmdirSync(dirPath);
try {
fs.rmdirSync(dirPath);
} catch (_err) {
// Nothing
}
}

function compareDirectory(actual, expected) {
Expand Down
30 changes: 13 additions & 17 deletions test/emit-option.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,42 +315,38 @@ describe("emit option", () => {

await del([outputPath]);

const compiler1 = webpack(webpackConfig);
const compiler = webpack(webpackConfig);

await new Promise((resolve, reject) => {
compiler1.run((error, stats) => {
compiler.run((error, stats) => {
if (error) {
reject(error);

return;
}

compiler1.close(() => {
expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
`assets`
);
expect(
Array.from(stats.compilation.emittedAssets).sort()
).toMatchSnapshot(`emittedAssets`);
expect(getWarnings(stats)).toMatchSnapshot("warnings");
expect(getErrors(stats)).toMatchSnapshot("errors");
expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
`assets`
);
expect(
Array.from(stats.compilation.emittedAssets).sort()
).toMatchSnapshot(`emittedAssets`);
expect(getWarnings(stats)).toMatchSnapshot("warnings");
expect(getErrors(stats)).toMatchSnapshot("errors");

resolve();
});
resolve();
});
});

const compiler2 = webpack(webpackConfig);

await new Promise((resolve, reject) => {
compiler2.run((error, stats) => {
compiler.run((error, stats) => {
if (error) {
reject(error);

return;
}

compiler2.close(() => {
compiler.close(() => {
expect(Object.keys(stats.compilation.assets).sort()).toMatchSnapshot(
`assets`
);
Expand Down
Loading