Skip to content

fix: avoid to throw error when link doesn't have parentNode #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2023
Merged

fix: avoid to throw error when link doesn't have parentNode #1016

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08032b1
fix: avoid to throw error when link doesn't have parentNode
VieZhong Feb 14, 2023
9189ab8
refactor: add space after if
VieZhong Feb 16, 2023
2ecbe35
fix: fix test case error
VieZhong Feb 20, 2023
0ace6b9
fix: fix test case error
VieZhong Feb 20, 2023
9e6409d
Merge branch 'master' into master
VieZhong Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ class MiniCssExtractPlugin {
'err.code = "CSS_CHUNK_LOAD_FAILED";',
"err.type = errorType;",
"err.request = realHref;",
"linkTag.parentNode.removeChild(linkTag)",
"if(linkTag.parentNode) linkTag.parentNode.removeChild(linkTag)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add space after if

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-akait I fixed it. Please review again~

"reject(err);",
]),
"}",
Expand Down