Skip to content

fix: handling \ character #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2021
Merged

fix: handling \ character #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1efa52
fix: handling `\` character
cap-Bernardito Feb 10, 2021
7a06f04
test: update
cap-Bernardito Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,13 +370,17 @@ export function parseSrc(input) {
return { value, startIndex };
}

export function normalizeUrl(url) {
return decodeURI(url).replace(/[\t\n\r]/g, '');
}

const moduleRequestRegex = /^[^?]*~/;
const matchNativeWin32Path = /^[A-Z]:[/\\]|^\\\\/i;

export function normalizeUrl(url) {
return matchNativeWin32Path.test(url)
? decodeURI(url).replace(/[\t\n\r]/g, '')
: decodeURI(url)
.replace(/[\t\n\r]/g, '')
.replace(/\\/g, '/');
}

export function requestify(url) {
if (matchNativeWin32Path.test(url) || url[0] === '/') {
return url;
Expand Down
42 changes: 36 additions & 6 deletions test/__snapshots__/esModule-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

14 changes: 12 additions & 2 deletions test/__snapshots__/loader.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

66 changes: 54 additions & 12 deletions test/__snapshots__/minimize-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

180 changes: 152 additions & 28 deletions test/__snapshots__/sources-option.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion test/fixtures/simple.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,4 +436,9 @@ <h2>An Ordered HTML List</h2>

<meta itemprop="a" content="./image.png" />
<meta itemprop="b" content="./image.png" />
<meta itemprop=" " content="./image.png" />
<meta itemprop=" " content="./image.png" />

<img src='.\nested\image3.png' />
<img src='\nested\image3.png' />
<img src='/nested\image3.png' />
<img src='nested\image3.png' />