`rc.1` breaks when `remove: false,` property is set with `Error: No errors` message

[filipesilva]

Versions: using extract-text-webpack-plugin@2.0.0-rc.1, node@7.4.0, OS: any
Repro steps - include remove:false in

    rules: [
      {
        test: /\.css$/,
        use: ExtractTextPlugin.extract({
          remove: false,
          fallbackLoader: "style-loader",
          use: "css-loader"
        })
      }
    ]

Run webpack, see similar error message:

No errors
Error: No errors
    at validate (/home/carlos/empresa.com.br/PROJECT/node_modules/extract-text-webpack-plugin/schema/validator.js:10:9)
    at Function.ExtractTextPlugin.extract (/home/carlos/empresa.com.br/PROJECT/node_modules/extract-text-webpack-plugin/index.js:188:3)
    at /home/carlos/empresa.com.br/PROJECT/node_modules/angular-cli/models/webpack-build-styles.js:79:83
    at Array.map (native)
    at Object.getWebpackStylesConfig (/home/carlos/empresa.com.br/PROJECT/node_modules/angular-cli/models/webpack-build-styles.js:76:43)
    at new NgCliWebpackConfig (/home/carlos/empresa.com.br/PROJECT/node_modules/angular-cli/models/webpack-config.js:44:51)
    at Class.run (/home/carlos/empresa.com.br/PROJECT/node_modules/angular-cli/tasks/serve-webpack.js:23:22)
    at /home/carlos/empresa.com.br/PROJECT/node_modules/angular-cli/commands/serve.run.js:37:22
    at process._tickCallback (internal/process/next_tick.js:103:7)

This specific message was generated using angular-cli (angular/angular-cli#4264).

In there we use remove: false, which still seems to exist (https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/loader.js#L40) but not be accepted starting in rc.1.

I'm not sure if the property itself is deprecated since it doesn't show in https://github.com/webpack-contrib/extract-text-webpack-plugin/blob/master/CHANGELOG.md.

[bebraw]

Yeah. If I'm interpreting right, both omit and remove fields should be added to the schema as the pitch loader depends on those.

That error is weird, though. It should throw something about extra fields instead of No errors.

[niieani]

I'm getting the same error (No errors) whenever any wrong field is passed in, either when creating and instance or running .extract.

[bebraw]

@scottdj92 Just getting you here. We probably missed a couple of test cases.

[bebraw]

I see the validator bit. It should be something along

  const ajv = new Ajv({
    useDefaults: true // This mutates the original data with defaults!
  });
  const isValid = ajv.validate(schema, data);

  return {
    isValid,
    error: ajv.errors && ajv.errorsText()
  };

over the current code to comply with ajv API.

[bebraw]

I have a couple of fixes at #372 in case someone wants to give those a go.

[filipesilva]

@bebraw I tested your branch with remove: false, on the loader itself:
(ng build is the command that uses webpack to compile)

$ ng build
No errors
Error: No errors
    at validate (D:\work\angular-cli\node_modules\extract-text-webpack-plugin\schema\validator.js:10:9)
    // ...

$ npm install github:bebraw/extract-text-webpack-plugin#fix-schema
// ...

$ ng build
data should NOT have additional properties
Error: data should NOT have additional properties
    at validate (D:\work\angular-cli\node_modules\extract-text-webpack-plugin\schema\validator.js:10:9)

[filipesilva]

It seems like having remove: true shouldn't show data should NOT have additional properties, since it should be a valid property.

[bebraw]

@filipesilva Are you sure it's complaining about remove: true? You have use: "css-loader" in extract. That's not valid.

[filipesilva]

I think it's remove: false, since everything builds correctly after I remove it.

We have some fairly involved logic but the only change I did to test is this: