chore: improve unit tests feedback loop by making them asynchronous #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
them asynchronous
alexander-akait
approved these changes
Jan 12, 2024
ricardogobbosouza
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
When contributing on #237 and #238, when a test failed it had to reach the timeout to display the error.
Using async/await makes it so that when a test fails, the error is printed immediately.
This reduces the feedback loop and makes it easier to make changes.
The downside is that it hides the webpack API behind an indirection layer.
I'll let you judge if this is something you want to have or not.
Breaking Changes
N/A
Additional Info