feat: use emit event instead of this-compilation

[ijpiantanida]

Given that compression is most likely one of the last steps on the pipeline chain, it makes sense that this plugin uses the emit event which is the last step to add/modify assets before they're written to disk.

This plays nicely with other plugins that create and delete files on the fly AFTER they're compiled (for example https://github.com/jtefera/merge-files-webpack, which is the recommended solution for this issue webpack-contrib/extract-text-webpack-plugin#179)

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 9 committers have signed the CLA.

✅ sokra
✅ Icehunter
✅ d3viant0ne
✅ ijpiantanida
❌ shama
❌ codechaotic
❌ rufman
❌ robertbachmann
❌ Jason Palmer

---

Jason Palmer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[iGitScor]

Hi,

That's exactly what I was looking for, I've the same issue.
I agree with you, the good step to compress assets can't be optimize-assets, as I understood it.

[joshwiens]

Given that #26 will require a MAJOR anyway, ignore the above and just default it and we will roll this, #26 and the webpack-defaults upgrade into a single major version release.

Defaults will have to come first to get the testing framework in place & both #45 & #26 will then need to be accompanied by tests before they land.

I'll handle the defaults upgrade this evening.

[retwedt]

+1 I'm looking for this support as well!

[genu]

Can we resolve this? What more needs to be done here?

[farhan687]

Thanks for this awesome plugin, I am looking for this feature.

[sobolevn]

This feature is totally required.

[Igor-Vuk]

Is there some workaround until it is resolved?

[ijpiantanida]

@michael-ciniawsky what needs to be done to get this merged?

[michael-ciniawsky]

A rebase :) but according to the CLA Bot there a commits from others which didn't sign the CLA and therefore commit authors would need to by changed via git. The usage of webpack-defaults (repo boilerplate) also change a lot in the overall code base, so you may prefer to start afresh with a new PR

[ijpiantanida]

Replaced by #71