Skip to content
This repository was archived by the owner on Jun 25, 2020. It is now read-only.
This repository was archived by the owner on Jun 25, 2020. It is now read-only.

Does not support require.ensure error callback added in Webpack 2.4 #45

Open
@jharris4

Description

@jharris4

Webpack 2.4 added support for error callbacks as a 2nd argument to require.ensure:

webpack/webpack#4069

This is not supported by the bundle-loader, but there is a forked version of the loader that does support the require.ensure error callback: https://github.com/jharris4/split-chunk-loader

I'd consider making a PR to merge the changes from split-chunk-loader into bundle-loader, but not sure of the best way to handle the fact that webpack >= 2.4 is required for that to work. Maybe adding a peerDependency would do the trick?

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions