Skip to content

Conversation

vhenzl
Copy link
Contributor

@vhenzl vhenzl commented Sep 17, 2021

See graphql/graphql-js#1707

Resolves one of the problems responsible for many test failures in #928 and #929.

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #940 (cec4c36) into master (6e80894) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cec4c36 differs from pull request most recent head 796a788. Consider uploading reports for the commit 796a788 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             master     #940   +/-   ##
=========================================
  Coverage     94.23%   94.23%           
  Complexity       50       50           
=========================================
  Files           117      117           
  Lines          9674     9683    +9     
=========================================
+ Hits           9116     9125    +9     
  Misses          558      558           
Impacted Files Coverage Δ
src/Utils/SchemaPrinter.php 99.04% <100.00%> (+0.10%) ⬆️
src/Language/BlockString.php 100.00% <0.00%> (ø)
src/Language/Printer.php 99.28% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e80894...796a788. Read the comment docs.

@spawnia
Copy link
Collaborator

spawnia commented Sep 30, 2021

Superseded by #941?

@vhenzl
Copy link
Contributor Author

vhenzl commented Sep 30, 2021

Superseded by #941?

No, they are independent changes.

@spawnia spawnia merged commit 95580be into webonyx:master Sep 30, 2021
@vhenzl vhenzl deleted the print-empty-types branch October 1, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants