Skip to content

Conversation

fabis94
Copy link
Contributor

@fabis94 fabis94 commented Dec 3, 2020

Making class methods protected isn't enough to be able to override them, because all of them call each other using self:: not static::

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 86.186% when pulling 4e29b00 on fabis94:master into 8795c03 on webonyx:master.

Copy link
Collaborator

@spawnia spawnia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That opens the door for easier extensibility, nice.

@fabis94
Copy link
Contributor Author

fabis94 commented Dec 3, 2020

@spawnia when can I expect this to be merged/published?

@spawnia
Copy link
Collaborator

spawnia commented Dec 3, 2020

We typically wait for @vladar to show up and merge. This is a small change which I do feel confident about including, but so far that has been our modus operandi.

@spawnia spawnia changed the title Fixed SchemaPrinter so that it uses late static printing Fixed SchemaPrinter so that it uses late static binding Dec 3, 2020
@vladar vladar merged commit 7f2a9d1 into webonyx:master Dec 3, 2020
@vladar
Copy link
Member

vladar commented Dec 3, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants