Skip to content

Fix handling of concurrent deployments #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion create-deployment.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,16 @@ exports.createDeployment = async function(applicationName, fullRepositoryName, b
break;
} catch (e) {
if (e.code == 'DeploymentLimitExceededException') {
var [, otherDeployment] = e.message.toString().match(/is already deploying deployment \'(d-\w+)\'/);
let message = e.message.toString();
let found = message.match(/(?:is already deploying|already has an active Deployment) \'(d-\w+)\'/);

if (!found) {
console.log(`🐞 Unexpected exception message: ${message}`);
core.setFailed('Aborting');
throw e;
}

let [, otherDeployment] = found;
console.log(`😶 Waiting for another pending deployment ${otherDeployment}`);
try {
await codeDeploy.waitFor('deploymentSuccessful', {deploymentId: otherDeployment}).promise();
Expand Down
11 changes: 10 additions & 1 deletion dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,16 @@ exports.createDeployment = async function(applicationName, fullRepositoryName, b
break;
} catch (e) {
if (e.code == 'DeploymentLimitExceededException') {
var [, otherDeployment] = e.message.toString().match(/is already deploying deployment \'(d-\w+)\'/);
let message = e.message.toString();
let found = message.match(/(?:is already deploying|already has an active Deployment) \'(d-\w+)\'/);

if (!found) {
console.log(`🐞 Unexpected exception message: ${message}`);
core.setFailed('Aborting');
throw e;
}

let [, otherDeployment] = found;
console.log(`😶 Waiting for another pending deployment ${otherDeployment}`);
try {
await codeDeploy.waitFor('deploymentSuccessful', {deploymentId: otherDeployment}).promise();
Expand Down