feat: upgrade-to-yarn-remove-node-modules-folder #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Shreyas281299 merged 4 commits into webex:node-upgrade from Shreyas281299:move-to-packages

Oct 14, 2024

Contributor

Shreyas281299 commented Oct 8, 2024 •

edited

Loading

Completes -SPARK-559074

My suggestion on how to review this PR - close the packages folder, it only has file name changes. After that its a small PR

This PR is the first in the series of many PRs to create react-widgets a yarn workspace

This PR completes the first two tasks in the list bellow

Tasks required to make react-widgets a yarn workspace

Move components out of node_modules
Adjust the tooling to use the new paths
Enable yarn workspace in react-widget
Add dependencies inside each package
Add scripts for each package
Fix tooling to use yarn workspaces packages

Checks

Build is passing
UTs are passing
Integration tests are passing

Testing

Ran build:all
Served all the demos
Uts are passing.

Issues found

All these errors are persistent in master and node-upgrade branch also

People list has ENOENT  error while building - any css file thats why this error - its doesnt affect anything 
Widget-meet has ENOENT - any css file thats why this error - its doesnt affect anything 
All demo components fails the buildES function.
Issue with tsconfig- webpack build fails for all ts 'widget' components
Failling command - npm run deploy is failing in master and node-upgrade as well
We are ignoring all the src files for eslint tests
journey tests are failling in the node-upgrade branch as well


          feat: move-components-out-of-node-modules

4f8e861

Shreyas281299 commented

View reviewed changes

packages/node_modules/@webex/react-component-adaptive-card/package.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

packages/node_modules/@webex/react-component-md-text-input/package.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

packages/node_modules/@webex/react-component-md-choiceset-input/package.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

packages/node_modules/@webex/react-component-md-toggle-input/package.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

package-lock.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

tsconfig.json Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

scripts/utils/package.js Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

scripts/utils/build.js Show resolved Hide resolved


          fix(tooling): fix-build-issue

66f34d4

Shreyas281299 commented

View reviewed changes

scripts/utils/build.js Show resolved Hide resolved

Shreyas281299 commented

View reviewed changes

scripts/webpack/webpack-calling.prod.babel.js Show resolved Hide resolved


          fix(eslint): fix-eslint-ignore

63b16b9

Shreyas281299 commented

View reviewed changes

.eslintignore Show resolved Hide resolved

Shreyas281299 mentioned this pull request

tolling(workspace): turn-react-widgets-into-a-yarn-workspace Shreyas281299/react-widgets#13

Closed

9 tasks

mkesavan13 approved these changes

View reviewed changes

Contributor

mkesavan13 left a comment

Mostly looks good. Just one question. Approving

packages/@webex/react-component-adaptive-card/package.json Show resolved Hide resolved

Contributor

mkesavan13 commented Oct 10, 2024

Should we re-word the PR title?

Shreyas281299 changed the title ~~feat: move-components-out-of-node-modules~~ feat: upgrade-to-yarn-remove-node-modules-folder

Contributor Author

Shreyas281299 commented Oct 10, 2024

Should we re-word the PR title?

Updated

Kesari3008 approved these changes

View reviewed changes

Contributor

Kesari3008 left a comment

Minor comments

packages/@webex/webex-sign-in-page/package.json Show resolved Hide resolved

packages/@webex/webex-widget-base/package.json Show resolved Hide resolved

packages/@webex/widget-call-history/package.json Show resolved Hide resolved

packages/@webex/widget-number-pad/package.json Show resolved Hide resolved

packages/@webex/widget-speed-dial/package.json Show resolved Hide resolved

packages/@webex/widget-voice-mail/package.json Show resolved Hide resolved

scripts/build/commands/dist.js Outdated Show resolved Hide resolved

scripts/utils/build.js Show resolved Hide resolved


          fix(tooling): review-comments

304c7c3

Shreyas281299 merged commit 4cbd7b3 into webex:node-upgrade

1 check failed

Shreyas281299 mentioned this pull request

Create workspace #1440

Closed

9 tasks

Shreyas281299 mentioned this pull request

feat(tooling): convert-repo-to-yarn-workspace #1443

Merged

9 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet