Skip to content

Renamed callContractMethod to call for ReadOperation #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2023
Merged

Renamed callContractMethod to call for ReadOperation #735

merged 1 commit into from
Jan 23, 2023

Conversation

albertopeam
Copy link
Contributor

Summary of Changes

Fixes #727

Test Data or Screenshots

Local and remote tests runs correctly locally

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@albertopeam albertopeam mentioned this pull request Jan 22, 2023
Open
@JeneaVranceanu JeneaVranceanu changed the base branch from develop to develop-4.0 January 22, 2023 15:02
@JeneaVranceanu JeneaVranceanu changed the base branch from develop-4.0 to develop January 22, 2023 15:06
@JeneaVranceanu JeneaVranceanu changed the base branch from develop to develop-4.0 January 22, 2023 15:06
@JeneaVranceanu
Copy link
Collaborator

@albertopeam I've changed the target branch to develop-4.0. It just wasn't up to date.

janndriessen
janndriessen approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@janndriessen janndriessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 🙏

@JeneaVranceanu
Copy link
Collaborator

Two people approved - merging.

@JeneaVranceanu JeneaVranceanu merged commit 763ed34 into web3swift-team:develop-4.0 Jan 23, 2023
@albertopeam albertopeam deleted the feature/rename-callContractMethod branch January 23, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@JeneaVranceanu JeneaVranceanu JeneaVranceanu approved these changes

@yaroslavyaroslav yaroslavyaroslav Awaiting requested review from yaroslavyaroslav

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename callContractMethod to call
3 participants
@albertopeam @JeneaVranceanu @janndriessen