Feat: 3.4 support and JSON dump #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrconlin
force-pushed
the
feat/3.4
branch
5 times, most recently
from
4442e98 to
507952d
Compare
pjenvey
approved these changes
Mar 16, 2017
| T_PUBLIC_RAW = ( | ||
| "BBCcCWavxjfIyW6NRhqclO9IZj9oW1gFKUBSgwcigfNc" | ||
| "pXSfRk5JQTOcahMLjzO1bkHMoiw4b6L7YTyF8foLEEU" | ||
| ).strip('=') |
Member
Author
There was a problem hiding this comment.
Was planning on keeping it. It just turned out that key generation didn't include padding, but we want to make sure it isn't included in any future keys.
pjenvey
reviewed
Mar 16, 2017
| # Easy VAPID generation | ||
|
|
||
| This minimal library contains the minimal set of functions you need to | ||
| generate a VAPID key set and get the headers you'll need to sign a |
Collaborator
There was a problem hiding this comment.
Looks like you're moving the .md -> .rst but forgot to delete the .md?
Member
Author
There was a problem hiding this comment.
Keeping it as well. There are a lot of apps that like .md more than .rst, and it's a simple script to convert. (In fact, it's part of my publish script pandoc --from=markdown --to=rst --output README.rst README.md ) I'm ok with dropping the .rst from the repo, but since it's part of the python packaging, I'd rather keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several raw print statements that needed fixing. Also:
--jsonwill now dump the headers as a JSON blob. This should makeimporting the data into other functions a bit easier.
closes #29, #30