Update name and a.k.a of picture-in-picture #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
|
This doesn't conflict with #983 but it will break CI if it lands after that PR, and vice versa. Reviewers, please don't merge, and I'll take care of updating the other PR when one lands. |
ddbeck
reviewed
Apr 29, 2024
Since there's a document picture-in-picture feature and this API is video-specific, it makes sense to call this video picture-in-picture. Also add the common PiP shorthand to the description.
Co-authored-by: Daniel D. Beck <[email protected]>
ddbeck
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there's a document picture-in-picture feature and this API is
video-specific, it makes sense to call this video picture-in-picture.
Also add the common PiP shorthand to the description.