Skip to content

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Mar 27, 2024

No description provided.

@@ -0,0 +1,9 @@
name: font-size-adjust
description: The `font-size-adjust` CSS property sets the size of lowercase letters relative to the size of uppercase letters.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drott is this a reasonable description of this feature for web developers?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is inaccurate, the MDN text is also too specific to lowercase letters and incorrect, as the property allows more than that.

perhaps:

The font-size-adjust property provides a way to preserve apparent size of text across fonts in the fallback chain by adjusting the used font size so that the specified metric is scaled to the same size regardless of the font used.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so it allows matching of all of the font metrics listed in the spec and MDN? That's ex-height, cap-height, ch-width, ic-width, and ic-height. Do all implementations support all of these, or will we need to break this feature up into varying levels of support?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I expect all impls to support all of them. We discussed whether ic-height is needed or going to be removed from the spec, but that discussion has shifted to what we do when a metric is unavailable in the font.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drott! I took your suggested text and tried to simplify it just a little bit, but hopefully not to the point where it's wrong now. @ddbeck can you review?

@ddbeck ddbeck merged commit 717ded7 into main Apr 9, 2024
@ddbeck ddbeck deleted the font-size-adjust branch April 9, 2024 14:52
@ddbeck ddbeck added the feature definition Creating or defining new features or groups of features. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants