-
Notifications
You must be signed in to change notification settings - Fork 196
Add scroll to text fragment feature #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
56b3eff
Add scroll to text fragment feature
foolip afe9745
Update and rename scroll-to-text-fragment.yml to text-fragments.yml
foolip 1278c15
Update text-fragments.yml
foolip 9997e34
Update feature-group-definitions/text-fragments.yml
foolip b9acf55
Update feature-group-definitions/text-fragments.yml
foolip 52018f3
Update text-fragments.yml
foolip ffb19ea
Update text-fragments.yml
foolip File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| name: Text fragments | ||
| description: Text fragments link to a snippet of text within a page. The browser may scroll, highlight, or otherwise bring that text to the reader's attention. The text is specified in a URL fragment on the form `#:~:text=snippet` and can be styled using the `::target-text` pseudo-element. | ||
| spec: https://wicg.github.io/scroll-to-text-fragment/ | ||
| usage_stats: https://chromestatus.com/metrics/feature/timeline/popularity/2901 | ||
foolip marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| caniuse: url-scroll-to-text-fragment | ||
| compat_features: | ||
| - api.Document.fragmentDirective | ||
| - api.FragmentDirective | ||
| - css.selectors.target-text | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to honor the precedent of MDN with "text fragments", maybe we could add some specificity to the end:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, what about our principle of shortest plausible name?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"URL references for text fragments"?
Maybe it helps to think about a name for this feature when also thinking about how we used to only have links to ids before. I would have called that "URL references to fragment identifiers" and not just "Fragment identifiers", I assume.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just "fragment identifiers" is what I would call that actually. I remember that from https://www.w3.org/TR/media-frags/ where "media fragments" were defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I thought the existing name wasn't completely credible. Over in #732 (comment) you seemed unimpressed with "text fragments" alone. 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have shut up 😆
"Text fragments" is a bit generic, but it is the best name I can come up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's merge this as written. If it ends up being too vague when it is presented to developers, I'm sure we'll get feedback about it.