Skip to content

Conversation

@foolip
Copy link
Collaborator

@foolip foolip commented Feb 15, 2024

No description provided.

foolip added a commit to foolip/web-features that referenced this pull request Feb 16, 2024
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideas for putting the unique things first in the names here

@foolip
Copy link
Collaborator Author

foolip commented Mar 18, 2024

@ddbeck do you want me to attempt descriptions for these to simplify the names? Or do you think "CSS" and "function" should be in the names too?

@ddbeck
Copy link
Collaborator

ddbeck commented Mar 19, 2024

@foolip I'd be happy with simplified names with descriptions, yes. Or even just simplified names. I assumed there was some kind of special distinguishing going on here with the names (e.g., maybe you wanted to avoid confusion with Math.max() or something), so I tried to maintain the intent of keeping "CSS" in the names. But if we can drop them too, then let's do it.

@foolip foolip requested a review from ddbeck March 22, 2024 00:05
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Thank you @foolip!

@ddbeck ddbeck merged commit c0734ce into main Mar 24, 2024
@ddbeck ddbeck deleted the css-math branch March 24, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants