Check every key (regardless of compute_from) for discouraged condition #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tools and infrastructure
ddbeck
force-pushed
the
surface-discouraged-on-compute-from
branch
from
e77a819 to
e5e7442
Compare
This reverts commit 6bcde4d.
Elchi3
approved these changes
Nov 14, 2024
Collaborator
Author
|
OK, then if we're going down this route we have a little bit of work to do. These are the keys currently failing the test:
|
ddbeck
commented
Nov 20, 2024
| if (!source.draft_date) { | ||
| logger.error( | ||
| `${id}: contains at least one deprecated compat feature and can never be Baseline. This is forbidden for published features.`, | ||
| `${id}: contains at least one deprecated compat feature. This is forbidden for published features.`, |
Collaborator
Author
There was a problem hiding this comment.
This is kinda annoying in some cases, because you never get the one key that caused it. I should refactor this a bit, to conditionally check deprecated for each key up here.
Collaborator
|
@vwallen Can you open PRs for the remaining keys in this comment? |
This was referenced Nov 21, 2024
Collaborator
|
@ddbeck The blocking keys have been removed, and it looks like none have been added in the interim. |
Collaborator
Author
|
Great. Let's merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1894. If
compute_fromis set, then explicitly check every key'sdeprecatedvalue.Right now this is not great—it's quite slow. I need to do some sort of refactoring here to not run computeBaseline on every key twice. It's too late in the day for me to think that through.