Add more keys to flexbox #2186
Merged
Add more keys to flexbox #2186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
captainbrosset
approved these changes
Nov 8, 2024
Contributor
|
I agree that's probably the right thing to do now, but it's worth asking ourselves whether we should re-think about this. The place/align/justify CSS properties can/will be used in grid, flex, multi-col, block. |
Collaborator
Author
Agreed. Linking this to #1173 as another use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing to note- there are some property keys here like
css.properties.align-contentorcss.properties.align-itemsthat also work ingrid(and elsewhere). I chose to put them with flexbox, since that was where they were introduced.