-
Notifications
You must be signed in to change notification settings - Fork 195
Selectors- Add baseline high #2171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some optional description suggestions here, but I'm happy with this merging whenever you think it's ready.
features/form-validity-pseudos.yml
Outdated
| @@ -0,0 +1,18 @@ | |||
| name: Form validity pseudo-classes | |||
| description: "The form validity CSS pseudo-classes match <form> elements that are `:valid` or `:invalid`, `:optional` or `:required`, or in or out of an acceptable range." | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little nervous about using syntax as words in this way. Here's my suggested route instead. Also I think it'd be nice if this showed up in a search for "constraint" (as with the constraint validation API).
| description: "The form validity CSS pseudo-classes match <form> elements that are `:valid` or `:invalid`, `:optional` or `:required`, or in or out of an acceptable range." | |
| description: "The form validity CSS pseudo-classes match `<form>` elements based on the constraints of a form field, such as validity (`:valid`, `:invalid`, `:in-range`, `:out-of-range`) and necessity (`:optional` or `:required`)." |
| status: | ||
| compute_from: css.selectors.any-link | ||
| compat_features: | ||
| - css.selectors.any-link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had no idea this one existed—every day I'm learning about some new-to-me thing on this project. Cool, but slightly concerning.
features/scope-pseudo.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: :scope pseudo-class | |||
| description: The `:scope` CSS pseudo-class represents the scoping root, for instance the element that `querySelector()` is called on. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| description: The `:scope` CSS pseudo-class represents the scoping root, for instance the element that `querySelector()` is called on. | |
| description: The `:scope` CSS pseudo-class matches the scoping root, for instance the element that `querySelector()` is called on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description should also mention that the pseudo-class is useful when used inside @scope blocks.
MDN:
When used inside a @scope block, :scope matches the block's defined scope root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Added.
features/scope-pseudo.yml
Outdated
| @@ -0,0 +1,7 @@ | |||
| name: :scope pseudo-class | |||
| description: The `:scope` CSS pseudo-class represents the scoping root, for instance the element that `querySelector()` is called on. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description should also mention that the pseudo-class is useful when used inside @scope blocks.
MDN:
When used inside a @scope block, :scope matches the block's defined scope root.
See #2170 for more info