Adds attr features #2109
Merged
Adds attr features #2109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
captainbrosset
requested changes
Oct 30, 2024
Co-authored-by: Patrick Brosset <[email protected]>
captainbrosset
approved these changes
Nov 4, 2024
ddbeck
reviewed
Nov 4, 2024
features/contents-attr.yml
Outdated
There was a problem hiding this comment.
Let's rename this to attr-contents
Co-authored-by: Daniel D. Beck <[email protected]>
github-actions
bot
added
documentation
vwallen
force-pushed
the
css-values-5-attr
branch
from
01c2eb0 to
6dd1af7
Compare
captainbrosset
approved these changes
Nov 5, 2024
ddbeck
removed
the
tools and infrastructure
ddbeck
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unusual case as the feature has high support, but only as part of
contentsdeclarations. General usage per the spec is very limited.I chose to split the supported declaration into its own feature. The
contents: attr()feature would be reasonable to link tocaniuse: css-gencontentbut that is already in use inbefore-after. if duplicate caniuse values are acceptable, then this should be added.