Skip to content

Conversation

@captainbrosset
Copy link
Contributor

This isn't a complete list, but it's a good start.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Oct 24, 2024
@captainbrosset captainbrosset requested a review from ddbeck October 31, 2024 13:15
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and a question. Cheers!

@captainbrosset
Copy link
Contributor Author

@ddbeck I think this is now about ready. The BCD changes have landed and we've got them here. There's a few more manifest-related features that can be created, but those can always be added later.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'm happy with this too. I have one question and one suggestion, but this is super close to landing. You're welcome to merge this after you've considered (and/or acted on) the suggestions. Thank you!

@captainbrosset captainbrosset enabled auto-merge (squash) November 21, 2024 14:54
@captainbrosset captainbrosset merged commit f578f22 into main Nov 21, 2024
3 checks passed
@captainbrosset captainbrosset deleted the manifest branch November 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature definition Creating or defining new features or groups of features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants