Add dist refresh workflow #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddbeck
force-pushed
the
refresh-dist-workflow
branch
from
77f9896 to
32fc267
Compare
captainbrosset
approved these changes
Jun 7, 2024
foolip
approved these changes
Jun 7, 2024
.github/workflows/refresh_dist.yml
Outdated
| env: | ||
| CHANGED_FEATURES: ${{ steps.changed-files.outputs.all_changed_files }} | ||
| run: | | ||
| npx tsx scripts/dist.ts ${CHANGED_FEATURES} |
There was a problem hiding this comment.
Suggested change
| npx tsx scripts/dist.ts ${CHANGED_FEATURES} | |
| npm run dist ${CHANGED_FEATURES} |
@captainbrosset Yes, this is a good idea too, though I don't know know much about pre-commit hooks (I rarely use or make them myself). Though even if we had a hook, we'd still need this for changes applied during GitHub PR reviews or via the web editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Actions workflow that lets reviewers request a dist file refresh by adding a
refresh distlabel to the pull request. It only refreshes dists where the dist or authored YAML has changed on the PR, relative to the target branch.A known limitation: this will only work for owners/peers on the repo, who can set labels on a PR.