Add a print and print-events features (with print group)
#1039
Conversation
github-actions
bot
added
the
feature definition
features/print.yml
Outdated
| @@ -0,0 +1,8 @@ | |||
| name: Printing | |||
There was a problem hiding this comment.
With a name this broad, how do we explain that CSS page breaking features aren't a part of it?
I think a group for printing might make more sense, and that we have one feature for print(), and another for the events. I assume the events also fire when the user initiates printing, so they're not tied to the API.
There was a problem hiding this comment.
Since we're following caniuse here, we could do this (and rename the feature to something like print-events):
| name: Printing | |
| name: Printing events |
I think this is defensible since the spec specifies that beforeprint and afterprint must fire for before and after window.print() as well as when the user requests printing.
There was a problem hiding this comment.
print + print-events + media-print features sounds good to me. The last one not in this PR however, we'll need to think more about media query features in general.
foolip
left a comment
foolip
left a comment
There was a problem hiding this comment.
A thought on the description, but feel free to merge with or without changes.
Co-authored-by: Philip Jägenstedt <[email protected]>
ddbeck
changed the title
print featureprint and print-events features (with print group)
2 participants
This is a Baseline 2023 feature.