-
Notifications
You must be signed in to change notification settings - Fork 195
Add scroll-driven-animations.dist.yml #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ddbeck
merged 1 commit into
web-platform-dx:main
from
foolip:dist-scroll-driven-animations
Apr 30, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
feature-group-definitions/scroll-driven-animations.dist.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # Generated from: scroll-driven-animations.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| name: Scroll-driven animations | ||
| description: CSS scroll-driven animations are a type of CSS animations that don't run over time, but are instead driven by the user's scroll position. | ||
| spec: https://drafts.csswg.org/scroll-animations-1/ | ||
| status: | ||
| baseline: false | ||
| support: | ||
| chrome: "115" | ||
| chrome_android: "115" | ||
| edge: "115" | ||
| compat_features: | ||
| - api.ScrollTimeline | ||
| - api.ScrollTimeline.axis | ||
| - api.ScrollTimeline.ScrollTimeline | ||
| - api.ScrollTimeline.source | ||
| - api.ViewTimeline | ||
| - api.ViewTimeline.endOffset | ||
| - api.ViewTimeline.startOffset | ||
| - api.ViewTimeline.subject | ||
| - api.ViewTimeline.ViewTimeline | ||
| - css.properties.animation-range | ||
| - css.properties.animation-range-end | ||
| - css.properties.animation-range-start | ||
| - css.properties.animation-timeline | ||
| - css.properties.animation-timeline.scroll | ||
| - css.properties.animation-timeline.view | ||
| # https://crbug.com/337580010 tracks this bug, but setting the timeline via | ||
| # the animation shorthand is not necessary to use the feature. | ||
| # - css.properties.animation.animation-timeline_included | ||
| - css.properties.scroll-timeline | ||
| - css.properties.scroll-timeline-axis | ||
| - css.properties.scroll-timeline-name | ||
| # Later addition (Chrome 116) | ||
| # - css.properties.timeline-scope | ||
| - css.properties.view-timeline | ||
| - css.properties.view-timeline-axis | ||
| - css.properties.view-timeline-inset | ||
| - css.properties.view-timeline-name | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to be convinced on this. What's the case for pulling this one out, when they landed just four weeks apart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://chromestatus.com/feature/6752840701706240 says 115 and I expect caniuse would say 115 too if it was added. One bit of an API coming a release later is pretty common I think. Unless it's a terrible accident and the feature is unusable without that bit, I think #979 is the way to handle such cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe @bramus can share some insights about whether the
timeline-scopeproperty is a vital part of scroll-driven-animations, or whether the feature is mostly usable without it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeline-scopeis there for when want to animate an element based on a scroller that is not a parent of the animated element.In most cases though, the animation subject is a child of the scroller – I’ve only used
timeline-scopea few times in my demos.