fix: correct ESM interop #1193
Merged
fix: correct ESM interop #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework
force-pushed
the
interop
branch
2 times, most recently
from
c5706a1 to
d09dacc
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes ESM (ECMAScript Modules) interop issues by porting a fix from Rsbuild that corrects module type handling. The fix ensures proper handling of modules when bundling for different formats.
- Adds a new
fixJsModuleTypePluginthat removes the 'type' setting from JavaScript module rules - Applies the fix across all output formats (ESM, CJS, UMD, IIFE, MF) to ensure consistent module handling
- Includes comprehensive test coverage for ESM interop scenarios
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Implements the core fix by adding fixJsModuleTypePlugin and applying it to all format configurations |
| tests/integration/format/index.test.ts | Adds integration test to verify ESM interop works correctly |
| tests/integration/format/esm-interop/* | Creates test fixture with module import/export scenarios |
| packages/core/tests/config.test.ts | Adds snapshot testing for the new configuration |
| packages/core/setupRstestTests.ts | Sets up test environment with snapshot serialization |
| packages/core/rstest.config.ts | Configures test setup file |
| packages/core/package.json | Adds path-serializer dependency for testing |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Timeless0911
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
port web-infra-dev/rsbuild#5955 before it can landed in Rsbuild (too much breaking as of now, may land it in v2).
fix #1185.
Related Links
Checklist