Skip to content

Conversation

@gaoachao
Copy link
Contributor

@gaoachao gaoachao commented Oct 17, 2024

Summary

Related Links

close #3701

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit ef79681
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67127058a620480009710ba2
😎 Deploy Preview https://deploy-preview-3752--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 78 (🔴 down 1 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan
Copy link
Member

Hi, is this PR ready for review?

@gaoachao gaoachao marked this pull request as ready for review October 18, 2024 14:28
@gaoachao
Copy link
Contributor Author

It's ready for review!

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@chenjiahan chenjiahan merged commit 6692b42 into web-infra-dev:main Oct 19, 2024
9 checks passed
@chenjiahan chenjiahan changed the title feat: output.filename.css allow function feat: output.filename.css allow function Oct 19, 2024
@chenjiahan chenjiahan mentioned this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: output.filename.css should allow a function

2 participants