-
Notifications
You must be signed in to change notification settings - Fork 397
fix(plugin-runtime): streaming ssr split chunk so that can't match SHELL_STREAM_END_MARK
#3719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…LL_STREAM_END_MARK
🦋 Changeset detectedLatest commit: 270a36b The changes in this PR will be included in the next version bump. This PR includes changesets to release 207 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SHELL_STREAM_END_MARK
SHELL_STREAM_END_MARK
SHELL_STREAM_END_MARK
SHELL_STREAM_END_MARK
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3719 +/- ##
==========================================
+ Coverage 57.59% 58.14% +0.54%
==========================================
Files 672 643 -29
Lines 17794 17177 -617
Branches 3876 3751 -125
==========================================
- Hits 10249 9987 -262
+ Misses 6934 6589 -345
+ Partials 611 601 -10 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at b9a5615
This pull request improves the streaming SSR feature for the
@modern-js/runtime
package by refactoring the logic, fixing bugs, and adding type annotations. It also updates the version and the changeset file for the package.Details
🤖 Generated by Copilot at b9a5615
@modern-js/runtime
package (link)ShellChunkStatus
enum and initialize theshellChunkStatus
variable with theSTART
state for the streaming SSR feature (link, link)chunkVec
array, instead of concatenating them with the shell template on the fly, inrenderToPipe.ts
(link)chunkVec
array, instead of on each chunk, and remove the escaping of the end mark, inrenderToPipe.ts
(link)data
parameter in theDeferredDataScript
component, which renders a script tag with the deferred data for the SSR page, inDeferredDataScripts.node.tsx
(link)shellBefore
andshellAfter
properties of theInjectTemplate
type required, instead of optional, intype.ts
(link)Related Issue
Checklist
pnpm run change
.